Re: [Xen-devel] [PATCH V3] x86/altp2m: add altp2m_vcpu_disable_notify

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 1/2/19 1:50 PM, Wei Liu wrote:
> On Tue, Dec 18, 2018 at 05:11:44PM +0200, Razvan Cojocaru wrote:
>> Allow altp2m users to disable #VE/VMFUNC alone. Currently it is
>> only possible to disable this functionality when we disable altp2m
>> completely; #VE/VMFUNC can only be enabled once per altp2m session.
>>
>> In addition to making things complete, disabling #VE is also a
>> workaround for CFW116 ("When Virtualization Exceptions are Enabled,
>> EPT Violations May Generate Erroneous Virtualization Exceptions")
>> on Xeon E-2100 CPUs.
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
>>
>> ---
>> Changes since V2:
>>  - Fixed compilation by completing the removal of all references
>>    to "pad".
>>
>> Changes since V1:
>>  - Updated the patch description to specify E-2100.
>>  - Made trying to disable #VE when it's already disabled a no-op.
>>  - Removed leftover uint32_t pad; from struct
>>    xen_hvm_altp2m_vcpu_disable_notify.
>> ---
>>  tools/libxc/include/xenctrl.h   |  2 ++
>>  tools/libxc/xc_altp2m.c         | 22 ++++++++++++++++++++++
>>  xen/arch/x86/hvm/hvm.c          | 28 ++++++++++++++++++++++++++++
>>  xen/include/public/hvm/hvm_op.h | 11 ++++++++++-
>>  4 files changed, 62 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
>> index 97ae965..31cdda7 100644
>> --- a/tools/libxc/include/xenctrl.h
>> +++ b/tools/libxc/include/xenctrl.h
>> @@ -1932,6 +1932,8 @@ int xc_altp2m_get_domain_state(xc_interface *handle, 
>> uint32_t dom, bool *state);
>>  int xc_altp2m_set_domain_state(xc_interface *handle, uint32_t dom, bool 
>> state);
>>  int xc_altp2m_set_vcpu_enable_notify(xc_interface *handle, uint32_t domid,
>>                                       uint32_t vcpuid, xen_pfn_t gfn);
>> +int xc_altp2m_set_vcpu_disable_notify(xc_interface *handle, uint32_t domid,
>> +                                      uint32_t vcpuid);
>>  int xc_altp2m_create_view(xc_interface *handle, uint32_t domid,
>>                            xenmem_access_t default_access, uint16_t 
>> *view_id);
>>  int xc_altp2m_destroy_view(xc_interface *handle, uint32_t domid,
>> diff --git a/tools/libxc/xc_altp2m.c b/tools/libxc/xc_altp2m.c
>> index 844b9f1..f8cd603 100644
>> --- a/tools/libxc/xc_altp2m.c
>> +++ b/tools/libxc/xc_altp2m.c
>> @@ -91,6 +91,28 @@ int xc_altp2m_set_vcpu_enable_notify(xc_interface 
>> *handle, uint32_t domid,
>>      return rc;
>>  }
>>  
>> +int xc_altp2m_set_vcpu_disable_notify(xc_interface *handle, uint32_t domid,
>> +                                      uint32_t vcpuid)
>> +{
>> +    int rc;
>> +    DECLARE_HYPERCALL_BUFFER(xen_hvm_altp2m_op_t, arg);
>> +
>> +    arg = xc_hypercall_buffer_alloc(handle, arg, sizeof(*arg));
>> +    if ( arg == NULL )
>> +        return -1;
>> +
>> +    arg->version = HVMOP_ALTP2M_INTERFACE_VERSION;
>> +    arg->cmd = HVMOP_altp2m_vcpu_disable_notify;
>> +    arg->domain = domid;
>> +    arg->u.disable_notify.vcpu_id = vcpuid;
>> +
>> +    rc = xencall2(handle->xcall, __HYPERVISOR_hvm_op, HVMOP_altp2m,
>> +              HYPERCALL_BUFFER_AS_ARG(arg));
> 
> Tabs here.

Right, that was copy/pasted from xc_altp2m_set_vcpu_enable_notify() - it
turns out that most function in that source file have the tab problem.
I'll fix them all while at it.

> With this fixed:
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Thanks!


Happy new year,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel