Re: [Xen-devel] [PATCH XTF v2 3/4] xtf: Add monitor test class

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Dec 28, 2018 at 08:42:41PM +0200, Petre Pircalabu wrote:
> This class starts alongside the domain a monitor application which opens
> an event channel corresponding to that domain and handles the received
> requests.
> Use the "monitor_args" key to pass test specific arguments to the
> monitor application.
> The arguments will be added in the test's Makefile using the
> TEST-EXTRA-INFO variable.
> 
> Signed-off-by: Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>
> ---
>  Makefile                  |   6 +-
>  build/common.mk           |  22 ++-
>  build/files.mk            |   3 +
>  build/gen.mk              |  12 ++
>  common/report.c           |   8 -
>  docs/all-tests.dox        |   3 +
>  include/monitor/monitor.h | 136 +++++++++++++
>  include/xtf/report.h      |   8 +
>  monitor/Makefile          |  20 ++
>  monitor/monitor.c         | 481 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  xtf/__init__.py           |   2 +-
>  xtf/monitor_test.py       | 132 +++++++++++++
>  xtf/utils.py              |  17 ++
>  13 files changed, 838 insertions(+), 12 deletions(-)
>  create mode 100644 include/monitor/monitor.h
>  create mode 100644 monitor/Makefile
>  create mode 100644 monitor/monitor.c
>  create mode 100644 xtf/monitor_test.py
>  create mode 100644 xtf/utils.py
> 
> diff --git a/Makefile b/Makefile
> index 15a865f..db28075 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -32,7 +32,9 @@ INSTALL_PROGRAM := $(INSTALL) -p
>  OBJCOPY         := $(CROSS_COMPILE)objcopy
>  PYTHON          := python
>  
> -export CC CPP INSTALL INSTALL_DATA INSTALL_DIR INSTALL_PROGRAM OBJCOPY PYTHON
> +HOSTCC          := gcc
> +
> +export CC CPP INSTALL INSTALL_DATA INSTALL_DIR INSTALL_PROGRAM OBJCOPY 
> PYTHON HOSTCC
>  
>  .PHONY: all
>  all:
> @@ -51,7 +53,7 @@ install:
>       done
>  
>  define all_sources
> -     find include/ arch/ common/ tests/ -name "*.[hcsS]"
> +     find include/ arch/ common/ tests/ monitor/ -name "*.[hcsS]"
>  endef

Not a maintainer of xtf, but I find this code placement strange. If
"monitor" is a just yet one category of tests, why is it not placed
under tests/ ?

>  
>  .PHONY: cscope
> diff --git a/build/common.mk b/build/common.mk
> index b786ddf..1ec0fa4 100644
> --- a/build/common.mk
> +++ b/build/common.mk
> @@ -1,4 +1,4 @@
> -ALL_CATEGORIES     := special functional xsa utility in-development
> +ALL_CATEGORIES     := special functional xsa utility in-development monitor

You use "monitor" here but "host" in previous patch. They don't match.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel