Re: [Xen-devel] [PATCH 2/8] viridian: separately allocate domain and vcpu structures

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Dec 20, 2018 at 04:33:39PM +0000, Paul Durrant wrote:
>  
>  void viridian_vcpu_deinit(struct vcpu *v)
>  {
> -    viridian_synic_wrmsr(v, HV_X64_MSR_VP_ASSIST_PAGE, 0);
> +    if ( !v->arch.hvm.viridian )
> +        return;
> +
> +    if ( is_viridian_vcpu(v) )
> +        viridian_synic_wrmsr(v, HV_X64_MSR_VP_ASSIST_PAGE, 0);
> +
> +    xfree(v->arch.hvm.viridian);
> +    v->arch.hvm.viridian = NULL;

Please use XFREE() here and below.

With it fixed:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel