Re: [Xen-devel] [PATCH v7 06/14] libxl_qmp: Implementation of libxl__ev_qmp_*

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Jan 03, 2019 at 12:40:18PM +0000, Anthony PERARD wrote:
> On Fri, Dec 21, 2018 at 03:36:18PM +0000, Ian Jackson wrote:
> > Anthony PERARD writes ("[PATCH v7 06/14] libxl_qmp: Implementation of 
> > libxl__ev_qmp_*"):
> > > +static void qmp_ev_set_state(libxl__gc *gc, libxl__ev_qmp *ev,
> > > +                             libxl__qmp_state new_state)
> > > +    /* on entry: !broken and !disconnected */
> > > +{
[...]
> > > +
> > > +    ev->state = new_state;
> > 
> > I think this function needs to update efd ?  What am I missing ?
> 
> Yes, I think it's fine to call qmp_ev_ensure_reading_writing here ( or
> even inline it) and qmp_ev_ensure_reading_writing won't needs to be
> call from other places.

Actually, I still need to update efd after having transmit data to QEMU,
as ev->state isn't updated in that case. So I'll have efd update when
qmp_ev_set_state is called, and when the tx_buf is maybe sent.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel