Re: [Xen-devel] [PATCH v2 1/4] xen/dom0: Improve documentation for dom0= and dom0-iommu=

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Dec 31, 2018 at 03:16:20PM +0000, Andrew Cooper wrote:
> +Controls for the dom0 IOMMU setup.
> +
> +*   The `passthrough` boolean controls whether IOMMU translation 
> functionality
> +    is disabled for devices in dom0 (`passthrough=1`) or whether the IOMMU is
> +    used to ensure that dom0 can only DMA to its permitted areas of RAM
> +    (`passthrough=0`).
> +
> +    This option is only applicable to x86 PV dom0's, and defaults to false.
> +
> +    Some older Intel VT-d hardware isn't capable of disabling translation
> +    functionality on a per-device basis, and will cause this option to be
> +    ignored and assumed to be 0.  Similar behaviour on such systems is only
> +    available by fully disabling all IOMMUs.
> +
> +    This option is hardwired to false for x86 PVH dom0's (where a 
> non-identity
> +    transform is required for dom0 to function), and is ignored for ARM.
> +
> +*   The `strict` boolean is applicable to x86 PV dom0's only and defaults to
> +    false.  It controls whether dom0 can have IOMMU mappings for all domain

I would remove 'domain' from the end of this line.

With or without that:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel