[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 4/4] xen/dom0: Add a dom0-iommu=none option

On Mon, Dec 31, 2018 at 03:16:23PM +0000, Andrew Cooper wrote:
> For development purposes, it is very convenient to boot Xen as a PVH guest,
> with an XTF PV or PVH "dom0".  The edit-compile-go cycle is a matter of
> seconds, and you can reasonably insert printk() debugging in places which
> which would be completely infeasible when booting fully-fledged guests.
> However, the PVH dom0 path insists on having a working IOMMU, which doesn't
> exist when virtualised as a PVH guest, and isn't necessary for XTF anyway.
> Introduce a developer mode to skip the IOMMU requirement.
> To fix a corner case with command line parsing, cmdline_strcmp() is
> introduced.  Because we no longer tokenise comma separated list with NUL's,
> strcmp(line, "opt") doesn't work for a string in the middle of the comma
> separated list, and strncmp("opt", s, ss - s) matches "o", "op" and "opt" on
> the command line.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Even with the cmdline_strcmp moved to a separate patch.

Thanks, Roger.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.