Re: [Xen-devel] [PATCH 3/5] x86/dom0: add missing flag to printf format for PVH

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.12.18 at 16:26, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/dom0_build.c
> +++ b/xen/arch/x86/hvm/dom0_build.c
> @@ -124,7 +124,7 @@ static int __init pvh_populate_memory_range(struct domain 
> *d,
>                                      order);
>          if ( rc != 0 )
>          {
> -            printk("Failed to populate memory: [%#lx,%lx): %d\n",
> +            printk("Failed to populate memory: [%#lx,%#lx): %d\n",
>                     start, start + (1UL << order), rc);

I think the change would better have been the other way around:
Serial console bandwidth considerations (like also mentioned
elsewhere on a few occasions) should lead to a preference of
shorter messages, as long as things don't become ambiguous.
Ambiguity is not an issue here - printing of MFNs in decimal is
entirely useless imo, and printing of error codes in hex (the more
that they're negative) should be considered bad practice at best.
Hence a mix of hex and dec here would be not an issue at all,
without any 0x prefixes.

But this is an error path, so my reply is not meant to be a call
for further action in this specific case.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel