Re: [Xen-devel] [PATCH v2 1/2] x86/dom0: take alignment into account when populating p2m in PVH mode

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Jan 04, 2019 at 07:42:35AM -0700, Jan Beulich wrote:
> >>> On 28.12.18 at 12:18, <roger.pau@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/hvm/dom0_build.c
> > +++ b/xen/arch/x86/hvm/dom0_build.c
> > @@ -91,16 +91,54 @@ static int __init pvh_populate_memory_range(struct 
> > domain *d,
> >                                              unsigned long start,
> >                                              unsigned long nr_pages)
> >  {
> > -    unsigned int order = MAX_ORDER, i = 0;
> > +    struct {
> > +        unsigned long align;
> 
> It's .init.* data only, but anyway - why "long" instead of "int"?

A mistake, unsigned int is fine to store the current alignments, will
send a patch to fix it.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel