Re: [Xen-devel] [PATCH 4/4] pci: add a pci section to the maintainers file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.01.19 at 11:33, <roger.pau@xxxxxxxxxx> wrote:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -259,6 +259,7 @@ X:        xen/drivers/passthrough/arm/
>  X:   xen/drivers/passthrough/vtd/
>  X:   xen/drivers/passthrough/x86/
>  X:   xen/drivers/passthrough/device_tree.c
> +X:   xen/drivers/passthrough/pci.c

Much like for patch 3, I'm not convinced this is appropriate.

> @@ -312,6 +313,14 @@ M:       Wei Liu <wei.liu2@xxxxxxxxxx>
>  S:   Supported
>  T:   git https://xenbits.xenproject.org/git-http/ovmf.git 
>  
> +PCI
> +M:   Jan Beulich <jbeulich@xxxxxxxx>
> +R:   Roger Pau Monné <roger.pau@xxxxxxxxxx>
> +S:   Supported
> +F:   xen/drivers/passthrough/pci.c
> +F:   xen/drivers/pci/
> +F:   xen/include/xen/pci*

I'm fine with the last two, but I think truly IOMMU-independent
code would better be moved from the file named first to a file in
the directory named second.

The whole situation arises from the origin of this code, which
back then was needed solely for the purposes of IOMMU
management.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel