Re: [Xen-devel] [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays

[Cornelia Huck <cohuck@xxxxxxxxxx>]

On Tue, 8 Jan 2019 07:45:43 +0100
Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:

>   Hi,
> 
> > +    { "migration", "decompress-error-check", "off" },
> > +    { "hda-audio", "use-timer", "false" },
> > +    { "cirrus-vga", "global-vmstate", "true" },
> > +    { "VGA", "global-vmstate", "true" },
> > +    { "vmware-svga", "global-vmstate", "true" },
> > +    { "qxl-vga", "global-vmstate", "true" },  
> 
> I'd like to have the fields aligned.  Especially in cases like this one
> where multiple devices get the same value assigned it makes things more
> readable:
> 
>     { "migration",   "decompress-error-check", "off"   },
>     { "hda-audio",   "use-timer",              "false" },
>     { "cirrus-vga",  "global-vmstate",         "true"  },
>     { "VGA",         "global-vmstate",         "true"  },
>     { "vmware-svga", "global-vmstate",         "true"  },
>     { "qxl-vga",     "global-vmstate",         "true"  },
> 
> thanks,
>   Gerd
> 

I'm a bit on the fence here. It does make things more readable (at
least in your example), but I find editing aligned tables a bit
annoying. OTOH, that won't happen often, anyway.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel