Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.01.19 at 13:26, <royger@xxxxxxxxxxx> wrote:
> On Thu, Jan 10, 2019 at 12:52 PM Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>
>>  >>> On 10.01.19 at 11:19, <royger@xxxxxxxxxxx> wrote:
>> > aOn Mon, Jan 7, 2019 at 8:44 AM Christopher Clark 
>> > <christopher.w.clark@xxxxxxxxx> wrote:
>> >>
>> >> +/* Xen command line option to enable argo */
>> >> +static bool __read_mostly opt_argo_enabled;
>> >> +boolean_param("argo", opt_argo_enabled);
>> >
>> > I would drop the opt_* prefix, new options added recently don't
>> > include the prefix already.
>>
>> Would you mind pointing out examples? Especially for boolean ones I
>> think we've tried to consistently name them opt_*. But in the case
>> here (it being static) I'm not overly fussed.
> 
> I was mostly thinking about the dom0_pvh boolean option that I added.
> I'm not overly fuzzed, I just think it's not adding any value to the
> variable name, but if you prefer to keep the opt_ prefix that's fine.

Well, one value is that at use sites of such variables you immediately
notice that the value is (potentially) admin controlled. At least in some
cases this is helpful to be obvious.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel