Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

[Christopher Clark <christopher.w.clark@xxxxxxxxx>]

On Wed, Jan 9, 2019 at 6:38 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
>
> >>> On 09.01.19 at 15:26, <jandryuk@xxxxxxxxx> wrote:
> > On Wed, Jan 9, 2019 at 4:35 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >> >>> On 08.01.19 at 23:54, <jandryuk@xxxxxxxxx> wrote:
> >> > On Mon, Jan 7, 2019 at 2:43 AM Christopher Clark 
> >> > <christopher.w.clark@xxxxxxxxx> wrote:
> >> >> +     */
> >> >> +    struct argo_ring_info *ring_info;
> >> >> +    /* domain to be notified when space is available */
> >> >> +    domid_t domain_id;
> >> >> +    uint16_t pad;
> >> >
> >> > Can we order domain_id after len and drop the pad?
> >>
> >> That would still call for a pad field - we prefer to have explicit padding,
> >> and also to check it's zero, the latter to allow for assigning meaning to
> >> the field down the road.
> >
> > This struct is internal to Xen and argo, so do we still need explicit
> > padding?
>
> Oh, internal structures don't need any explicit padding. Where the
> domain_id field gets placed still doesn't matter then, though.

ok, I've switched the len field here from uint32_t to unsigned int
(part of moving away from fixed-width types where not required, as
requested later in this thread) and so while at it have dropped the
unneeded pad field too.

Christopher

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel