Re: [Xen-devel] [PATCH for-4.12 V2] x86/p2m: fix p2m_finish_type_change()

[George Dunlap <George.Dunlap@xxxxxxxxxx>]

> On Jan 9, 2019, at 10:24 PM, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> 
> wrote:
> 
> finish_type_change() returns a negative int on error, but the
> current code checks if ( !rc ). We also need to treat
> finish_type_change()'s return codes cumulatively in the
> success case (don't overwrite a 1 returned while processing
> the hostp2m if processing an altp2m returns 0).
> 
> The breakage was introduced by commit 0fb4b58c8b
> ("x86/altp2m: fix display frozen when switching to a new view
> early").
> 
> Properly indent the out: label while at it.
> 
> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> 
> ---
> Changes since V1:
> - Updated description.
> - Now treating finish_type_change()'s return value cumulatively
>   for the success case.

Oh, I see you already did the more complicated thing.  I’m slightly worried 
about the return value of the hypercall, but since that was the semantic 
before, I guess it shouldn’t cause any problems:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel