Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

[Christopher Clark <christopher.w.clark@xxxxxxxxx>]

On Thu, Jan 10, 2019 at 3:57 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
>
>  >>> On 10.01.19 at 12:24, <royger@xxxxxxxxx> wrote:
> > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark 
> > <christopher.w.clark@xxxxxxxxx> wrote:
> >> +static long
> >> +register_ring(struct domain *currd,
> >
> > If this is indeed the current domain (as the name suggests), why do
> > you need to pass it around? Or else just name the parameter d.
>
> When all (or at least most) callers already latch the pointer into a
> local variable, handing it through is often cheaper than re-obtaining
> it as current->domain. ASSERT(currd == current->domain) might be
> worthwhile in such cases, though.

argument retained and ASSERTs added, thanks.

Christopher

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel