Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

[Christopher Clark <christopher.w.clark@xxxxxxxxx>]

On Mon, Jan 14, 2019 at 7:31 AM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 07/01/2019 07:42, Christopher Clark wrote:
> > diff --git a/docs/misc/xen-command-line.pandoc 
> > b/docs/misc/xen-command-line.pandoc
> > index aea13eb..68d4415 100644
> > --- a/docs/misc/xen-command-line.pandoc
> > +++ b/docs/misc/xen-command-line.pandoc
> > @@ -193,6 +193,21 @@ This allows domains access to the Argo hypercall, 
> > which supports registration
> >  of memory rings with the hypervisor to receive messages, sending messages 
> > to
> >  other domains by hypercall and querying the ring status of other domains.
> >
> > +### argo-mac
> > +> `= permissive | enforcing`
>
> Are these command line options already in use in the OpenXT community?

No, there's no concern there.

> I ask, because we are trying to avoid gaining multiple top level options
> for related functionatliy.
>
> IMO, this functionality could be covered more succinctly with:
>
>   argo = List of [ <bool>, mac = permissive | enforcing ]
>
> which also allows for cleaner addition of future options.
>
> (Unfortunately, to implement this, you need my cmdline_strcmp() fixes,
> which are still pending an ack.)

At Roger's recommendation, the "argo-mac" string option has become the
much simpler "argo-mac-permissive" boolean.

For 4.13, I'd like to improve the isolation of wildcard rings to the
point where they're able to be enabled whenever argo itself is, and
hopefully that will enable retiring this option altogether. If two
bools are tolerable for now (as this is still early and an
experimental feature), would it be OK to sort this out for 4.13?

Christopher

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel