Re: [Xen-devel] [PATCH v3 10/15] argo: implement the notify op

[Christopher Clark <christopher.w.clark@xxxxxxxxx>]

On Tue, Jan 15, 2019 at 12:06 AM Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
>
> On Mon, Jan 14, 2019 at 10:53:54PM -0800, Christopher Clark wrote:
> > On Thu, Jan 10, 2019 at 4:22 AM Roger Pau Monné <royger@xxxxxxxxxxx> wrote:
> > >
> > >  On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark
> > > <christopher.w.clark@xxxxxxxxx> wrote:
> > > > +
> > > > +    argo_dprintk("fill_ring_data: 
> > > > ent.ring.domain=%u,ent.ring.port=%x\n",
> > > > +                 ent.ring.domain_id, ent.ring.port);
> > > > +
> > > > +    ent.flags = 0;
> > >
> > > Please memset ent to 0 or initialize it to { }, or else you are
> > > leaking hypervisor stack data to the guest in the padding field.
> >
> > ok - I've added the initializer, thanks.
> > Was it really leaking stack data though because the struct should have
> > been fully populated, including the padding field, with the
> > __copy_from_guest above?
>
> That's my bad, there was no leak here. I somehow missed the
> copy_from_guest above, even when I made a comment on it. Please leave
> the code as-is.

ok - thanks for the quick response. I've taken the initializer back out.

Christopher

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel