Re: [Xen-devel] [PATCH] tools: only call git when necessary in OVMF Makefile

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Jan 15, 2019 at 11:09:40AM +0000, Wei Liu wrote:
> Users may choose to export a snapshot of OVMF and build it
> with xen.git supplied ovmf-makefile. In that case we don't
> need to call `git submodule`.
> 
> Fixes b16281870e.
> 
> Reported-by: Olaf Hering <olaf@xxxxxxxxx>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

> ---
>  tools/firmware/ovmf-makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/firmware/ovmf-makefile b/tools/firmware/ovmf-makefile
> index 3de2fc0300..55f9992145 100644
> --- a/tools/firmware/ovmf-makefile
> +++ b/tools/firmware/ovmf-makefile
> @@ -16,7 +16,7 @@ all: build
>  
>  .PHONY: build
>  build:
> -     $(GIT) submodule update --init --recursive
> +     if test -e .git ; then $(GIT) submodule update --init --recursive ; fi
>       OvmfPkg/build.sh -a X64 -b $(TARGET) -n 4
>       cp Build/OvmfX64/$(TARGET)_GCC*/FV/OVMF.fd ovmf.bin
>  
> -- 
> 2.11.0
> 

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel