Re: [Xen-devel] [PATCH v4 04/14] argo: init, destroy and soft-reset, with enable command line opt

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Roger Pau Monne writes ("Re: [PATCH v4 04/14] argo: init, destroy and 
soft-reset, with enable command line opt"):
> On Tue, Jan 15, 2019 at 01:27:36AM -0800, Christopher Clark wrote:
> > +    /* cached tx pointer location, protected by L3 */

I have not been following this in detail.  But I saw this go past and
I wanted to comment on the lock handling issue, but stepping back a
bit.

I applaud these detailed descriptions of what lock is protected by
what, and what the rules are, which are found in these comments.  Much
of the existing hypervisor code is much less explicit and this is a
recurrent source of bugs.  What I see here is much more like how
things ought to be.

We reviewers/maintainers/committers should be careful that this
attention is properly rewarded.  Under the circumstances I would
probably support a freeze exception, although of course the final
decision is with Juergen.

I'll leave the detailed commentary to others.

Regards,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel