[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 00/14] Argo: hypervisor-mediated interdomain communication

On Tue, Jan 15, 2019 at 01:27:32AM -0800, Christopher Clark wrote:
> Version four of this patch series.
> * Changes are primarily addressing feedback from the v3 series reviews.
>   Many points noted on the invididual commit posts.
> * Register ring interfaces uses Xen gfns as page identifiers,
>   and the arguments no longer specify page granularity.
> * Multi-level lock validation macros defined and applied.
>   Locks renamed to improve readability.
> * Hypercall argument struct checking is folded inline into the series,
>   checks applied as types are introduced.
> * argo-mac string boot parameter changed to argo-mac-permissive boolean
> Feedback items that are remaining to be addressed have been noted with
> comments in the commit message and at the location in the code.

Thanks. I've made some comments on the patches, but overall this LGTM.
Thanks for improving the locking names and the comments.

I think my only request would be to add the usage of vmap in order to
map the rings in a FIXME, so it's not forgotten. That can be likely
done after 4.12 if there are time constrains (and maybe more
important issues to solve).

Thanks, Roger.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.