Re: [Xen-devel] [PATCH v4 10/14] argo: implement the notify op

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.01.19 at 12:12, <roger.pau@xxxxxxxxxx> wrote:
> On Wed, Jan 16, 2019 at 10:54:48PM -0800, Christopher Clark wrote:
>> On Tue, Jan 15, 2019 at 8:19 AM Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
>> > On Tue, Jan 15, 2019 at 01:27:42AM -0800, Christopher Clark wrote:
>> > > +/* Sufficient space to queue space_required bytes exists */
>> > > +#define XEN_ARGO_RING_DATA_F_SUFFICIENT  (1U << 3)
>> >
>> > I would reword this as:
>> >
>> > "Sufficient space to queue space_required bytes might exists"
>> >
>> > Because AFAICT as soon as the hypervisor drops the L3 lock the space
>> > available might change, so the recipient of the notification or the
>> > return from the hypercall shouldn't expect that there _must_ be
>> > space_required available space on the ring.
>> 
>> ack. does this look ok? -:
>> 
>> + * Sufficient space to queue space_required bytes has become available.
>> + * If messages have been sent, it may not still be available.
> 
> I think my suggestion was shorter and clearer, but I'm not a native
> speaker so if you think the above is better and no one else complains
> that's fine for me.

FWIW I'd be fine with either, but with a small adjustment in each case:
In yours the trailing "s" looks wrong. In Christopher's I'd suggest it to
be "If further messages have been sent, ...".

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel