Re: [Xen-devel] [PATCH v2] x86/mm: Clean up p2m_finish_type_change return value

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.01.19 at 10:06, <aisaila@xxxxxxxxxxxxxxx> wrote:
> Changed the return value of 1 to 0 so now p2m_finish_type_change returns
> 0 for success or <0 for error.
> The “root” caller of p2m_finish_type_change() is
> XEN_DMOP_map_mem_type_to_ioreq_server and this does nothing useful with
> positive values.

By "root" I supposed you mean "only current"? I have to admit that
I'm only half way happy with this as the underlying reason. I would
expect for there to have been a reason for the return value being
this way, and that's what would need to be reasoned against.
Furthermore the question then is whether down the call tree the
same adjustment shouldn't be made. After all (and possibly just as
a first step) why would finish_type_change() return a positive
value if its only caller doesn't care?

But anyway, I'm not the maintainer here, so what I say may well
be completely ignored.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel