Re: [Xen-devel] [PATCH v8 1/7] xen: add assembly variables corresponding to linker symbols

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.01.19 at 00:35, <sstabellini@xxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/xen/arch/x86/x86_64/var.S
> @@ -0,0 +1,92 @@
> +GLOBAL(start_)
> +  .quad  _start

First of all I think it would be better if there was an abstracting macro
requiring exactly one line per symbol.

Next I don't think you want these symbols to end up in .text, in
which case you need to a .section directive.

And then, specific to this x86 instance - if we really need to go with
this, please move this up one level in the directory hierarchy.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel