[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS
On Mon, 21 Jan 2019 at 14:49, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote: > > When Xen is detected via pkg-config, it isn't necessary to modify > LDFLAGS as modifying libs_softmmu is enough. > > Reported-by: Peter Maydell <peter.maydell@xxxxxxxxxx> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> > --- > configure | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configure b/configure > index 12fd34f30b..98b270974d 100755 > --- a/configure > +++ b/configure > @@ -2355,7 +2355,6 @@ if test "$xen" != "no" ; then > fi > QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)" > libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu" > - LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS" > else > > xen_libs="-lxenstore -lxenctrl -lxenguest" > -- > Anthony PERARD Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx> Cc'ing MJT, who first pointed out to me that this bug was resulting in various binaries like the linux-user ones getting linked against the Xen libs unnecessarily. thanks -- PMM _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |