Re: [Xen-devel] [PATCH 3/3] x86/pvh: Print the PVH start info more concisely

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jan 21, 2019 at 03:37:21PM +0000, Andrew Cooper wrote:
> The current rendering of PVH start info in unnecessarily verbose, and doesn't
> clearly separate decimal and hex numbers.
> 
> All addresses are expected to be below the 4G boundary, so drop 8 redundant
> zeroes on all physical addresses.  Properly prefix all hex numbers, and fold
> related information onto the same line.
> 
> Before:
>   (XEN) PVH start info: (pa 0000ffc0)
>   (XEN)   version:    1
>   (XEN)   flags:      0
>   (XEN)   nr_modules: 1
>   (XEN)   modlist_pa: 000000000000ff80
>   (XEN)   cmdline_pa: 000000000000ffa0
>   (XEN)   cmdline:    'console=pv,xen'
>   (XEN)   rsdp_pa:    00000000fc009000
>   (XEN)     mod[0].pa:         0000000000599000
>   (XEN)     mod[0].size:       0000000001204224
>   (XEN)     mod[0].cmdline_pa: 0000000000000000
> 
> After:
>   (XEN) PVH start info: (pa 0x0000ffc0)
>   (XEN)   version 1, flags 0
>   (XEN)   cmdline 0x0000ffa0 'console=pv,xen'
>   (XEN)   rsdp    0xfc009000
>   (XEN)   modlist 0x0000ff80, nr 1
>   (XEN)     mod0 pa 0x005f4000, sz 0x00126000, cmdline 0x00000000
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel