Re: [Xen-devel] [PATCH] iommu: Eliminate an odd local variable

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.01.19 at 17:04, <andrii.anisov@xxxxxxxxx> wrote:
> Wipe out excessive lines from an iommu_unmap(), and align it with an
> iommu_map() code.

What's excessive there? How come you alter the function's
return value without saying why? The more that you make
it potentially return success when there was an error.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel