Re: [Xen-devel] [PATCH for-4.12] gic-vgic: fix assert condition

["Nuernberger, Stefan" <snu@xxxxxxxxx>]

On Thu, 2019-01-24 at 20:33 +0200, Andrii Anisov wrote:
> From: Andrii Anisov <andrii_anisov@xxxxxxxx>
> 
> Signed-off-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
> ---
>  xen/arch/arm/gic-vgic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c
> index 48922f5..684f2d1 100644
> --- a/xen/arch/arm/gic-vgic.c
> +++ b/xen/arch/arm/gic-vgic.c
> @@ -443,7 +443,7 @@ int vgic_connect_hw_irq(struct domain *d, struct
> vcpu *v, unsigned int virq,
>      int ret = 0;
>  
>      /* "desc" is optional when we disconnect an IRQ. */
> -    ASSERT(connect && desc);
> +    ASSERT(connect || desc);

I assume it should be ASSERT(!connect || desc);

- Stefan
>  
>      /* We are taking to rank lock to prevent parallel connections.
> */
>      vgic_lock_rank(v_target, rank, flags);
-- 
Amazon Development Center Germany GmbH
c/o Stefan Nuernberger
Am Brauhaus 12
01099 Dresden
Germany

Amtsgericht Charlottenburg - HRB 149173 B - UStID DE 289 237 879
Managing Directors: Ralf Herbrich, Chris Schlaeger



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrer: Christian Schlaeger, Ralf Herbrich
Ust-ID: DE 289 237 879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel