[Xen-devel] [OSSTEST PATCH 2/5] power: ssh: Fix handling of $delay

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

The script fragment contains a reference to $delay which is a perl
variable, not a variable in the script fragment.  We therefore need to
not ''-quote the script.

Without this, the ssh method will often fail spuriously: the exiting
parent (which will signal success back to the osstest controller)
races with the attempt to reboot.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 Osstest/PDU/ssh.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Osstest/PDU/ssh.pm b/Osstest/PDU/ssh.pm
index ac1eb919..cfcf8f85 100644
--- a/Osstest/PDU/ssh.pm
+++ b/Osstest/PDU/ssh.pm
@@ -47,7 +47,7 @@ sub pdu_power_state {
 
     my $delay = 5;
 
-    target_cmd_root($mo->{Host}, <<'END', 60);
+    target_cmd_root($mo->{Host}, <<END, 60);
  set -e
  type reboot
  exec >>/var/log/osstest-reboot.log
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel