Re: [Xen-devel] [PATCH v6 1/3] xen/pt: fix some pass-thru devices don't work across reboot

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.01.19 at 09:26, <chao.gao@xxxxxxxxx> wrote:
> --- a/xen/arch/x86/domctl.c
> +++ b/xen/arch/x86/domctl.c
> @@ -732,7 +732,11 @@ long arch_do_domctl(
>              break;
>  
>          ret = -EPERM;
> -        if ( irq <= 0 || !irq_access_permitted(currd, irq) )
> +        /*
> +         * irq < 0 denotes the corresponding pirq has been forcibly unbound.
> +         * For this case, bypass permission check to reap the pirq.
> +         */
> +        if ( !irq || ((irq > 0) && !irq_access_permitted(currd, irq)) )
>              break;

So why would it be correct to continue into pt_irq_destroy_bind()
with irq < 0? And with an actual XSM policy I'm not sure you'd
even make it past xsm_unbind_pt_irq(). If the IRQ was forcibly
unbound before, there shouldn't be anything left to clean up?

On the whole I think all the extra additions in v6 only serve to
mask the tool stack not needing to do anymore some of what it
does, as suggested in a reply to an earlier version. So I guess I
agree with Roger that v5 came closer, but may need to be
amended by some tool stack adjustment(s).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel