Re: [Xen-devel] [PATCH v6 02/15] argo: introduce the argo_op hypercall boilerplate

[Christopher Clark <christopher.w.clark@xxxxxxxxx>]

On Thu, Jan 24, 2019 at 2:08 AM Julien Grall <julien.grall@xxxxxxx> wrote:
>
> Hi,
>
> On 24/01/2019 02:04, Christopher Clark wrote:
> > Presence is gated upon CONFIG_ARGO.
> >
> > Registers the hypercall previously reserved for this.
> > Takes 5 arguments, does nothing and returns -ENOSYS.
> >
> > Will be avoiding a compat ABI by using fixed-size types in hypercall ops so
> > HYPERCALL, rather than COMPAT_CALL, is the correct macro for the hypercall
> > tables.
> >
> > Even though handles will be used for (up to) two of the arguments to the
> > hypercall, there will be no need for any XLAT_* translation functions
> > because the referenced data structures have been constructed to be exactly
> > the same size and bit pattern on both 32-bit and 64-bit guests, and padded
> > to be integer multiples of 32 bits in size. This means that the same
> > copy_to_guest and copy_from_guest logic can be relied upon to perform as
> > required without any further intervention. Testing communication with 32
> > and 64 bit guests has confirmed this works as intended.
> >
> > Signed-off-by: Christopher Clark <christopher.clark6@xxxxxxxxxxxxxx>
> > Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > v2 Copyright line: add 2019
> > v2 feedback #3 Jan: drop "message" from argo_message_op
> > v2 feedback #3 Jan: add Acked-by
> > v1 feedback #15 Jan: handle upper-halves of hypercall args
> > v1 feedback #15 Jan: use unsigned where negative values impossible
> > ---
> >   xen/arch/x86/guest/hypercall_page.S |  2 +-
> >   xen/arch/x86/hvm/hypercall.c        |  3 +++
> >   xen/arch/x86/hypercall.c            |  3 +++
> >   xen/arch/x86/pv/hypercall.c         |  3 +++
>
> Sorry for noticing quite late in the process. Don't you need to add the
> hypercall in xen/arch/arm/traps.c?

OK -- thanks. Will take a look.

Christopher

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel