Re: [Xen-devel] [PATCH v6 13/15] xsm, argo: XSM control for any access to argo by a domain

[Christopher Clark <christopher.w.clark@xxxxxxxxx>]

On Fri, Jan 25, 2019 at 5:32 PM Chris Patterson <cjp256@xxxxxxxxx> wrote:
>
> On Wed, Jan 23, 2019 at 9:07 PM Christopher Clark
> <christopher.w.clark@xxxxxxxxx> wrote:
> >
> > Will inhibit initialization of the domain's argo data structure to
> > prevent receiving any messages or notifications and access to any of
> > the argo hypercall operations.
> > diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
> > index 7c69efe..8daffae 100644
> > --- a/xen/include/xsm/xsm.h
> > +++ b/xen/include/xsm/xsm.h
> > @@ -182,6 +182,7 @@ struct xsm_operations {
> >      int (*xen_version) (uint32_t cmd);
> >      int (*domain_resource_map) (struct domain *d);
> >  #ifdef CONFIG_ARGO
> > +    int (*argo_enable) (const struct domain *d);
> >      int (*argo_register_single_source) (const struct domain *d,
> >                                          const struct domain *t);
> >      int (*argo_register_any_source) (const struct domain *d);
> > @@ -705,6 +706,11 @@ static inline int 
> > xsm_domain_resource_map(xsm_default_t def, struct domain *d)
> >  }
> >
> >  #ifdef CONFIG_ARGO
> > +static inline xsm_argo_enable(const struct domain *d)
>
> missing return type, fails to compile with XSM enabled:
> | /home/chris/git/xen/include/xsm/xsm.h:709:15: error: return type
> defaults to 'int' [-Werror=implicit-int]
> |  static inline xsm_argo_enable(const struct domain *d)

ack, repro'd and fixed -- thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel