Re: [Xen-devel] [PATCH v2 01/21] openrisc: prefer memblock APIs returning virtual address

[Stafford Horne <shorne@xxxxxxxxx>]

On Mon, Jan 21, 2019 at 10:03:48AM +0200, Mike Rapoport wrote:
> The allocation of the page tables memory in openrics uses
> memblock_phys_alloc() and then converts the returned physical address to
> virtual one. Use memblock_alloc_raw() and add a panic() if the allocation
> fails.
> 
> Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> ---
>  arch/openrisc/mm/init.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c
> index d157310..caeb418 100644
> --- a/arch/openrisc/mm/init.c
> +++ b/arch/openrisc/mm/init.c
> @@ -105,7 +105,10 @@ static void __init map_ram(void)
>                       }
>  
>                       /* Alloc one page for holding PTE's... */
> -                     pte = (pte_t *) __va(memblock_phys_alloc(PAGE_SIZE, 
> PAGE_SIZE));
> +                     pte = memblock_alloc_raw(PAGE_SIZE, PAGE_SIZE);
> +                     if (!pte)
> +                             panic("%s: Failed to allocate page for PTEs\n",
> +                                   __func__);
>                       set_pmd(pme, __pmd(_KERNPG_TABLE + __pa(pte)));
>  
>                       /* Fill the newly allocated page with PTE'S */

This seems reasonable to me.

Acked-by: Stafford Horne <shorne@xxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel