[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 1/8] microcode/intel: remove redundent check against ucode size

>>> Chao Gao <chao.gao@xxxxxxxxx> 01/28/19 8:06 AM >>>
>This check has been done in microcode_sanity_check(). Needn't do it
>again in get_matching_microcode().

But while there are two call sites of get_matching_microcode() only
one is preceded by a call to microcode_sanity_check(). There's also
no visible connection between cpu_request_microcode() (which frees
the blob it has validated) and microcode_resume_match() (and in
particular the blob passed into there). What am I missing?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.