Re: [Xen-devel] [PATCH v5 6/8] microcode: delete microcode pointer and size from microcode_info

[Chao Gao <chao.gao@xxxxxxxxx>]

On Tue, Jan 29, 2019 at 11:10:51AM +0100, Roger Pau Monné wrote:
>On Mon, Jan 28, 2019 at 03:06:48PM +0800, Chao Gao wrote:
>> microcode pointer and size were passed to other CPUs to parse
>> microcode locally. Now, parsing microcode is done on one CPU.
>> Other CPUs needn't parse the microcode blob; the pointer and
>> size can be removed.
>> 
>> Signed-off-by: Chao Gao <chao.gao@xxxxxxxxx>
>> ---
>>  xen/arch/x86/microcode.c | 33 +++++++++++++++++----------------
>>  1 file changed, 17 insertions(+), 16 deletions(-)
>> 
>> diff --git a/xen/arch/x86/microcode.c b/xen/arch/x86/microcode.c
>> index 936f0b8..3c2274f 100644
>> --- a/xen/arch/x86/microcode.c
>> +++ b/xen/arch/x86/microcode.c
>> @@ -190,9 +190,7 @@ DEFINE_PER_CPU(struct ucode_cpu_info, ucode_cpu_info);
>>  
>>  struct microcode_info {
>>      unsigned int cpu;
>
>I think cpu can also be removed as my previous reply to patch 5, at
>which point you only need to store an error? In which case you should
>also remove this struct then.

I agree to all your comments on this patch. Will correct them.

Thanks
Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel