Re: [Xen-devel] [PATCH v7 04/15] argo: init, destroy and soft-reset, with enable command line opt

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.01.19 at 17:05, <roger.pau@xxxxxxxxxx> wrote:
> On Thu, Jan 31, 2019 at 08:13:27AM -0700, Jan Beulich wrote:
>> >>> On 31.01.19 at 15:49, <roger.pau@xxxxxxxxxx> wrote:
>> > On Wed, Jan 30, 2019 at 08:28:09PM -0800, Christopher Clark wrote:
>> >> +static void
>> >> +pending_remove_all(const struct domain *d, struct argo_ring_info 
>> >> *ring_info)
>> >> +{
>> >> +    struct pending_ent *ent, *next;
>> >> +
>> >> +    ASSERT(LOCKING_L3(d, ring_info));
>> >> +
>> >> +    /* Delete all pending notifications from this ring's list. */
>> >> +    list_for_each_entry_safe(ent, next, &ring_info->pending, node)
>> > 
>> > list_first_entry_or_null and you can get rid of next.
>> 
>> Well, that's a substitution I wouldn't like to do while committing,
>> as it means doing a little more than a simple text replacement.
> 
> From a functionality PoV the code does exactly the same, I just think
> list_first_entry_or_null is more suitable and I haven't been convinced
> by the argument posted on v5.

Well, we're in agreement. All I did say is that a change like this
I'd like to see done by the submitter, not the committer (at least
not if I end up being the latter).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel