Re: [Xen-devel] [PATCH for-4.12] libxl: correctly dispose of dominfo list in libxl_name_to_domid

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Ian Jackson writes ("Re: [PATCH for-4.12] libxl: correctly dispose of dominfo 
list in libxl_name_to_domid"):
> Wei Liu writes ("[PATCH for-4.12] libxl: correctly dispose of dominfo list in 
> libxl_name_to_domid"):
> > Tamas reported ssid_label was leaked. Use the designated function to
> > free dominfo list to fix the leakage.
> > 
> > Reported-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Tested-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> > Backport candidate.
> 
> Noted.

For reference:

This bug was first introduced in

  35c1498503216510095745d06d09f0f01ddf800e
  libxenlight: fix name to domid conversion

where the call to libxl_domain_list was introduced.  A fix was
attempted in

  cbc97d570c09ff9a1db5af18f5e5db5565ab3506
  libxenlight: fix memory leaks

which is where the `free(dominfo)' call was introduced, but that was
not right.  That latter commit is in staging-3.4.  So all supported
(and security-supported) versions are affected.  I have backported
this to 4.10 and 4.11.  (As it doesn't seem to me to be a security
issue I have not fixed it on earlier branches.)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel