Re: [Xen-devel] [PATCH v3 6/8] p2m: change write_p2m_entry to return an error code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.02.19 at 18:48, <George.Dunlap@xxxxxxxxxx> wrote:
>> On Feb 15, 2019, at 2:18 PM, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
>> @@ -321,7 +321,7 @@ static int p2m_pt_set_recalc_range(struct p2m_domain 
>> *p2m,
>>             if ( (l1e_get_flags(e) & _PAGE_PRESENT) && !needs_recalc(l1, e) )
>>             {
>>                 set_recalc(l1, e);
>> -                p2m->write_p2m_entry(p2m, first_gfn, pent, e, level);
>> +                BUG_ON(p2m->write_p2m_entry(p2m, first_gfn, pent, e, 
>> level));
>>             }
> 
> Again here; theoretically, the only change has been that RECALC_FLAGS have 
> been added.
> 
> And so on.
> 
> Thoughts?  (Looking for input from Jan here as well.)

I'd indeed prefer a more fine grained (justified per instance) approach
like you suggest, but I wasn't really opposed to how it was done so far
as it didn't seem like any of the BUG_ON()-s should actually be able to
trigger, considering that there was no failure possible there till now.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel