Re: [Xen-devel] [PATCH v4 1/4] x86/mm: split p2m ioreq server pages special handling into helper

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.02.19 at 18:27, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -3188,6 +3188,9 @@ shadow_write_p2m_entry(struct domain *d, unsigned long 
> gfn,
>      if ( likely(d->arch.paging.shadow.total_pages != 0) )
>           sh_unshadow_for_p2m_change(d, gfn, p, new, level);
>  
> +    p2m_entry_modify(p2m_get_hostp2m(d), 
> p2m_flags_to_type(l1e_get_flags(new)),
> +                     p2m_flags_to_type(l1e_get_flags(*p)), level);
> +
>      /* Update the entry with new content */
>      safe_write_pte(p, new);

Strictly speaking you should Cc Tim for this change.

Also at this example (a possible issue elsewhere as well) - is
acting on the host P2M (only) really the right thing to do here?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel