Re: [Xen-devel] [PATCH 4/6] x86/vtd: Drop struct ir_ctrl

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
[snip]
>  struct iommu_flush {
>      int __must_check (*context)(void *iommu, u16 did, u16 source_id,
>                                  u8 function_mask, u64 type,
> @@ -523,7 +517,6 @@ struct iommu_flush {
>  };
> 
>  struct intel_iommu {
> -    struct ir_ctrl ir_ctrl;
>      struct iommu_flush flush;
>      struct acpi_drhd_unit *drhd;
>  };
> @@ -543,16 +536,15 @@ struct vtd_iommu {
> 
>      uint64_t qinval_maddr;   /* queue invalidation page machine address */
> 
> +    uint64_t iremap_maddr;   /* interrupt remap table machine address */
> +    unsigned int iremap_num; /* total num of used interrupt remap entry */
> +    spinlock_t iremap_lock;  /* lock for irq remapping table */
> +

Elsewhere in the Xen codebase we try to group related fields, so how ahout the 
following?

struct {
    uint64_t maddr;   /* interrupt remap table machine address */
    unsigned int num; /* total num of used interrupt remap entry */
    spinlock_t lock;  /* lock for irq remapping table */
} iremap;

You'd than have a fairly mechanical job of replacing '_' with '.' in a few 
places in your patch but I think it would look better overall.

  Paul

>      struct list_head ats_devices;
>      unsigned long *domid_bitmap;  /* domain id bitmap */
>      u16 *domid_map;               /* domain id mapping array */
>  };



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel