Re: [Xen-devel] [PATCH v3 9/9] viridian: add implementation of the HvSendSyntheticClusterIpi hypercall

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.01.19 at 11:47, <paul.durrant@xxxxxxxxxx> wrote:
> @@ -659,7 +663,64 @@ int viridian_hypercall(struct cpu_user_regs *regs)
>          status = HV_STATUS_SUCCESS;
>          break;
>      }
> +    case HvSendSyntheticClusterIpi:

Missing blank line again, and one more at the end of this case block.

> +    {
> +        struct vcpu *v;
> +        uint32_t vector;
> +        uint64_t vcpu_mask;
> +
> +        status = HV_STATUS_INVALID_PARAMETER;
> +
> +        /* Get input parameters. */
> +        if ( input.fast )
> +        {
> +            if ( input_params_gpa >> 32 != 0 )

Please parenthesize the shift expression (or omit the != 0).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel