Re: [Xen-devel] [PATCH] kexec: suppress bogus warning

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.02.19 at 14:33, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 25/02/2019 12:14, Jan Beulich wrote:
>>>>> On 25.02.19 at 12:52, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> On 25/02/2019 11:23, Jan Beulich wrote:
>>>> Don't emit the "ignored" warning when there's no placement specification
>>>> and the tail of the specified option is actually empty.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>> What command line triggers this?
>> crashkernel=1G-16G:1M
>>
>> is what I've used for repro-ing the original report.
> 
> Look like that yields:
> 
> (XEN) crashkernel: '' ignored
> (XEN) parameter "crashkernel" has invalid value "1G-16G:1M", rc=-22!
> 
> which looks like pertinent information in the commit message.

Hmm, odd - what is it that I didn't say with "when there's no placement
specification" plus the mention of the "ignored" message?

> So long as something like that gets included, Reviewed-by: Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>

Let me know whether what's there is really not good enough, and if so,
what exactly your expectation is. So far I wasn't really intending to give
an explicit example, and the one I've used for testing is rather contrived
anyway.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel