Re: [Xen-devel] [PATCH] x86/xstate: Don't special case feature collection

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.02.19 at 16:03, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -414,6 +414,10 @@ static void generic_identify(struct cpuinfo_x86 *c)
>                           
> &c->x86_capability[cpufeat_word(X86_FEATURE_FSGSBASE)],
>                           &c->x86_capability[cpufeat_word(X86_FEATURE_PKU)],
>                           
> &c->x86_capability[cpufeat_word(X86_FEATURE_AVX512_4VNNIW)]);
> +     if ( c->cpuid_level >= 0xd )
> +             cpuid_count(0xd, 1,
> +                         
> &c->x86_capability[cpufeat_word(X86_FEATURE_XSAVEOPT)],
> +                         &tmp, &tmp, &tmp);

I think this file is still trying to be Linux style, with a couple of
violations. I do notice that the immediately preceding if() is
the same style as the one you add, but I think it would be
more consistent to omit the blanks immediately inside the
parentheses here. Either way,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

I take it that you're intentionally using 0xd in favor of
XSTATE_CPUID?

As an aside I wonder why we have cpuid_count_ebx(), but
not e.g. cpuid_count_eax() as would have been useful here.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel