Re: [Xen-devel] [PATCH for-next v2 v2 1/5] build/m4: make python_devel.m4 work with both python 2 and 3

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Wed, Mar 06, 2019 at 05:52:06PM +0000, Wei Liu wrote:
> Do the following:
> 
> 1. Change the form of "print".
> 2. Use AC_CHECK_FUNC to avoid the need to generate library name.
> 3. Remove unused stuff.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks.

> ---
> I doubt the non-python-config branch works, because the paths generated
> seem rather off. It definitely doesn't work on my machine, but I
> don't know how other systems could possibly be configured before the
> existence of python-config.

It's probably fine. On Arch, the paths for python2 looks fine. With
python3, that would generates "-L/usr/lib/python3.7/config" which
doesn't exist, but the python lib is in /usr/lib, so it's probably going
to work just fine. Anyway, an installation of python3 without its
python-config is probably broken.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel