[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/6] x86: stop handling MSR_IA32_XSS save/restore in implementation code



>>> On 07.01.19 at 13:02, <paul.durrant@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/msr.c
> +++ b/xen/arch/x86/msr.c
> @@ -164,6 +164,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t 
> *val)
>  
>          break;
>  
> +    case MSR_IA32_XSS:
> +        if ( !is_hvm_domain(d) || !cp->xstate.xsaves )

Why the is_hvm_domain() check here and below? The CPUID policy bit
alone should properly reflect things, and there should be no change
needed here if we decided to support XSAVES also for PV guests. With
them dropped
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.