Re: [Xen-devel] [PATCH 2/6] block: don't merge adjacent bvecs to one segment in bio blk_queue_split

[Ming Lei <ming.lei@xxxxxxxxxx>]

On Mon, Mar 11, 2019 at 03:21:06PM +0100, Christoph Hellwig wrote:
> On Sat, Mar 09, 2019 at 09:37:33AM +0800, Ming Lei wrote:
> > For normal filesystem IO, each page is added via blk_add_page(),
> > in which bvec(page) merge has been handled already, and basically
> > not possible to merge two adjacent bvecs in one bio.
> > 
> > So not try to merge two adjacent bvecs in blk_queue_split(), also add
> > check if one page is mergeable to current bvec in bio_add_page() for
> > avoiding to break XEN.
> 
> Isn't this two entirely different things?  Both look good to me,
> but I don't understand why this is one patch vs two.

You are right, it should have been two things logically.

Thanks,
Ming

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel