Re: [Xen-devel] [PATCH v2] automation: enable building rombios with clang

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sat, Aug 25, 2018 at 10:01:38PM -0500, Doug Goldstein wrote:
> On Fri, Aug 24, 2018 at 04:34:35PM +0100, Wei Liu wrote:
> > On Fri, Aug 24, 2018 at 10:32:24AM -0500, Doug Goldstein wrote:
> > > On Fri, Aug 24, 2018 at 04:22:47PM +0100, Wei Liu wrote:
> > > > Previously it is disabled because the embedded ipxe can't be built
> > > > with clang. Now that ipxe is split out we can use --with-system-ipxe
> > > > to work around the issue.
> > > > 
> > > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > > ---
> > > > +    # iPXE cannot be built with clang
> > > > +    cfgargs+=("--with-system-ipxe=/usr/lib/ipxe/ipxe.pxe")
> > > 
> > > Did we ever get all the containers updated with this file in place?
> > 
> > No. I didn't. Do we care? Xen's build system doesn't check if that file
> > exists. It merely puts the string into appropriate places.
> > 
> > Wei.
> 
> Well then that works for me. Just wondering if you've pushed a branch
> with this and had GitLab run over it?

I take that "that works for me" as an approval. :-)

I will commit this patch shortly.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel