[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xen: drop the nop() macro
>>> On 15.03.19 at 14:41, <wei.liu2@xxxxxxxxxx> wrote: > On Fri, Mar 15, 2019 at 01:39:05PM +0000, Andrew Cooper wrote: >> There isn't a plausible reason to insert nops like this into code. >> >> The sole use is in do_debug_key(), and exists to prevent the compiler >> optimising the tail of the function with 'jmp debugger_trap_fatal' >> >> In practice, a compiler barrier suffices just as well to prevent the >> tailcall, >> and doesn't involve inserting unnecessary instructions. >> >> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > > Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |