Re: [Xen-devel] [PATCH v2 1/2] xen: add interface for obtaining .config from hypervisor

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.03.19 at 15:01, <jgross@xxxxxxxx> wrote:
> On 15/03/2019 14:57, Jan Beulich wrote:
>>>>> On 14.03.19 at 12:59, <jgross@xxxxxxxx> wrote:
>>> Add a sysctl interface for obtaining the .config file used to build
>>> the hypervisor. The mechanism is inspired by the Linux kernel's one.
>>>
>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> (apart from XSM changes)
>>> ---
>>> V2:
>>> - bump sysctl interface version
>> 
>> Judging from the style you use for other entries here this wasn't
>> a result of review feedback. Why did you do this? The change is
> 
> V1 was posted before 4.12 was branched away, so bumping would have
> clearly be wrong at that time.
> 
>> a plain addition to the interface, which doesn't require caller
>> awareness. My R-b does not hold with this in place.
> 
> Ah, I wasn't aware of this rule. I'll remove the bumping in case this
> can't be done when committing.

It's pretty straightforward to drop this while committing.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel