Re: [Xen-devel] [PATCH RFC 23/55] x86_64/mm: drop l4e_to_l3e invocation from paging_init

["Nuernberger, Stefan" <snu@xxxxxxxxx>]

On Thu, 2019-02-07 at 16:44 +0000, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Any reason why this isn't squashed with the previous patch?

- Stefan

> ---
>  xen/arch/x86/x86_64/mm.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
> index 02919481e4..094c609c8c 100644
> --- a/xen/arch/x86/x86_64/mm.c
> +++ b/xen/arch/x86/x86_64/mm.c
> @@ -648,8 +648,10 @@ void __init paging_init(void)
>      /* Create user-accessible L2 directory to map the MPT for compat
> guests. */
>      BUILD_BUG_ON(l4_table_offset(RDWR_MPT_VIRT_START) !=
>                   l4_table_offset(HIRO_COMPAT_MPT_VIRT_START));
> -    l3_ro_mpt = l4e_to_l3e(idle_pg_table[l4_table_offset(
> -        HIRO_COMPAT_MPT_VIRT_START)]);
> +
> +    l3_ro_mpt_mfn = l4e_get_mfn(idle_pg_table[l4_table_offset(
> +                                        HIRO_COMPAT_MPT_VIRT_START)]
> );
> +    l3_ro_mpt = map_xen_pagetable_new(l3_ro_mpt_mfn);
>  
>      l2_ro_mpt_mfn = alloc_xen_pagetable_new();
>      if ( mfn_eq(l2_ro_mpt_mfn, INVALID_MFN) )
> @@ -701,6 +703,7 @@ void __init paging_init(void)
>  #undef MFN
>  
>      UNMAP_XEN_PAGETABLE_NEW(l2_ro_mpt);
> +    UNMAP_XEN_PAGETABLE_NEW(l3_ro_mpt);
>  
>      machine_to_phys_mapping_valid = 1;
>  



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrer: Christian Schlaeger, Ralf Herbrich
Ust-ID: DE 289 237 879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel