Re: [Xen-devel] [PATCH 1/2] x86: decouple xen alignment setting from EFI/non-EFI build

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.03.19 at 12:24, <wei.liu2@xxxxxxxxxx> wrote:
> On Tue, Mar 19, 2019 at 04:45:35AM -0600, Jan Beulich wrote:
>> >>> On 18.03.19 at 15:57, <wei.liu2@xxxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/Kconfig
>> > +++ b/xen/arch/x86/Kconfig
>> > @@ -138,6 +138,32 @@ config TBOOT
>> >  
>> >      If unsure, say Y.
>> >  
>> > +choice
>> > +  prompt "Alignment of Xen binary"
>> > +  depends on X86
>> > +  default XEN_ALIGN_DEFAULT
>> > +  ---help---
>> > +    Specify alignment for Xen binary.
>> > +
>> > +    If unsure, choose "default".
>> > +
>> > +config XEN_ALIGN_DEFAULT
>> > +  bool "Default alignment"
>> > +  ---help---
>> > +    Pick alignment according to build variants.
>> > +
>> > +    For EFI build the default alignment is 2M. For non-EFI build
>> > +    the default alignment is 4K due to syslinux failing to handle
>> > +    2M alignment.
>> 
>> Wasn't it the resulting image size rather than the alignment itself
>> which did cause the problem? Has the issue been fixed in newer
>> syslinux?
>> 
> 
> Right. I can make this clearer.
> 
> "due to syslinux failing to handle the image size increment induced by
> 2M alignment".
> 
> Also, I think s/binary/image/ in the description would be better.

Agreed.

>> > +config XEN_ALIGN_4K
>> > +  bool "4K alignment"
>> > +
>> > +config XEN_ALIGN_2M
>> > +  bool "2M alignment"
>> 
>> In patch 2 you only need the latter - is there really much value in
>> allowing explicitly requesting 4k?
> 
> I thought there would be a case in which users want 4K explicitly? I'm
> certainly fine with dropping the 4K alignment option.

Well, without a specific need or request I'd prefer not to see extra
options introduced.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel