Re: [Xen-devel] [PATCH v1 1/2] xen/arm: Add Amlogic Meson SoCs earlyprintk support

[Julien Grall <julien.grall@xxxxxxx>]

On 3/21/19 7:20 AM, Amit Tomer wrote:
> Hi,
Hi,

> > Apart from this and the unneeded addition to early-printk.txt (which
> > Julien mentioned already) this looks now correct to me.
> I was wondering, if it's a good idea to have
> "CONFIG_EARLY_PRINTK=meson,0xc81004c0"
> documented in Rules.mk.
>
> It would give fair idea to someone who is new to Xen, how to compile
> meson with early printk support ?
Someone new to Xen is unlikely going to know that documentation is in 
Rules.mk.
But, documenting the exact UART address is not going to help a user with 
a platform different than yours. It can also lead the user to think his 
board is not supported by Xen when often this is just a different address.
This is why I want to phase out any alias in Xen. The best place to 
document the earlyprintk is on the wiki along with documentation to boot 
Xen on your platform.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel